diff options
author | Thedro Neely <thedroneely@gmail.com> | 2021-07-14 19:33:57 -0400 |
---|---|---|
committer | Thedro Neely <thedroneely@gmail.com> | 2021-07-14 19:33:57 -0400 |
commit | 9eb759feece6014bfed685946eac48c123071476 (patch) | |
tree | ac103c25b311cd5aee0579a8ffc936cb3edcff60 /app | |
parent | da2aa0f982adfe14907659cfeedc71893518bfb5 (diff) | |
download | thedroneely.com-9eb759feece6014bfed685946eac48c123071476.tar.gz thedroneely.com-9eb759feece6014bfed685946eac48c123071476.tar.bz2 thedroneely.com-9eb759feece6014bfed685946eac48c123071476.zip |
app/controllers/contact: Minor adjustments
Signal 403 to robots on empty.
Hide honey pot using position absolute.
Diffstat (limited to 'app')
-rw-r--r-- | app/controllers/contact.controller.php | 7 | ||||
-rw-r--r-- | app/model/Form.php | 9 |
2 files changed, 4 insertions, 12 deletions
diff --git a/app/controllers/contact.controller.php b/app/controllers/contact.controller.php index 504b979..797cccd 100644 --- a/app/controllers/contact.controller.php +++ b/app/controllers/contact.controller.php @@ -10,19 +10,16 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') { $form->spam = $spam = $_POST['agree'] ?? false; if ($form->empty()) { - include '../app/views/contact.view.php'; - return; + return http_response_code(403); } if ($form->spam()) { - error_log('Contact Form Spam: Error 403'); return http_response_code(403); } if ($form->emailValid() === false) { $emailError = 'Invalid email: ' . "\r" . '<b>'. $email . '</b>'; - include '../app/views/contact.view.php'; - return; + return include '../app/views/contact.view.php'; } $formSuccess = true; diff --git a/app/model/Form.php b/app/model/Form.php index 6520a9c..e55eadc 100644 --- a/app/model/Form.php +++ b/app/model/Form.php @@ -23,6 +23,7 @@ class Form if ((bool) empty($this->email) == true || (bool) empty($this->message) == true ) { + error_log('Contact Form Incomplete: Error 403'); return true; } } @@ -34,14 +35,11 @@ class Form public function submit() { - // Include mail config $config = include '../config.php'; $mail = new PHPMailer(true); try { - //Server settings - //$mail->SMTPDebug = 2; $mail->isSMTP(); $mail->SMTPAuth = true; $mail->SMTPSecure = 'ssl'; @@ -50,21 +48,18 @@ class Form $mail->Username = $config['mail']['username']; $mail->Password = $config['mail']['password']; - //Recipients $mail->setFrom($config['mail']['username'], $config['mail']['name']); $mail->addAddress($config['mail']['username'], $config['mail']['name']); - //Content $mail->isHTML(true); $mail->Subject = 'New message from ' . $this->email; $mail->Body = $this->message . "\n\n" . $this->name . "\n" . $this->email; $mail->AltBody = $this->message . "\n\n" . $this->name . "\n" . $this->email; - //Send Mail $mail->send(); } catch (Exception $exception) { - log_exception($exception); + error_log($exception); } } } |