From 9eb759feece6014bfed685946eac48c123071476 Mon Sep 17 00:00:00 2001
From: Thedro Neely <thedroneely@gmail.com>
Date: Wed, 14 Jul 2021 19:33:57 -0400
Subject: app/controllers/contact: Minor adjustments

Signal 403 to robots on empty.
Hide honey pot using position absolute.
---
 app/controllers/contact.controller.php | 7 ++-----
 app/model/Form.php                     | 9 ++-------
 2 files changed, 4 insertions(+), 12 deletions(-)

(limited to 'app')

diff --git a/app/controllers/contact.controller.php b/app/controllers/contact.controller.php
index 504b979..797cccd 100644
--- a/app/controllers/contact.controller.php
+++ b/app/controllers/contact.controller.php
@@ -10,19 +10,16 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
     $form->spam = $spam = $_POST['agree'] ?? false;
 
     if ($form->empty()) {
-        include '../app/views/contact.view.php';
-        return;
+        return http_response_code(403);
     }
 
     if ($form->spam()) {
-        error_log('Contact Form Spam: Error 403');
         return http_response_code(403);
     }
 
     if ($form->emailValid() === false) {
         $emailError = 'Invalid email: ' . "\r" . '<b>'. $email . '</b>';
-        include '../app/views/contact.view.php';
-        return;
+        return include '../app/views/contact.view.php';
     }
 
     $formSuccess = true;
diff --git a/app/model/Form.php b/app/model/Form.php
index 6520a9c..e55eadc 100644
--- a/app/model/Form.php
+++ b/app/model/Form.php
@@ -23,6 +23,7 @@ class Form
         if ((bool) empty($this->email) == true
             || (bool) empty($this->message) == true
         ) {
+            error_log('Contact Form Incomplete: Error 403');
             return true;
         }
     }
@@ -34,14 +35,11 @@ class Form
 
     public function submit()
     {
-        // Include mail config
         $config = include '../config.php';
 
         $mail = new PHPMailer(true);
 
         try {
-            //Server settings
-            //$mail->SMTPDebug = 2;
             $mail->isSMTP();
             $mail->SMTPAuth = true;
             $mail->SMTPSecure = 'ssl';
@@ -50,21 +48,18 @@ class Form
             $mail->Username = $config['mail']['username'];
             $mail->Password = $config['mail']['password'];
 
-            //Recipients
             $mail->setFrom($config['mail']['username'], $config['mail']['name']);
             $mail->addAddress($config['mail']['username'], $config['mail']['name']);
 
-            //Content
             $mail->isHTML(true);
             $mail->Subject = 'New message from ' . $this->email;
             $mail->Body    = $this->message . "\n\n" . $this->name . "\n" . $this->email;
             $mail->AltBody = $this->message . "\n\n" . $this->name . "\n" . $this->email;
 
-            //Send Mail
             $mail->send();
 
         } catch (Exception $exception) {
-            log_exception($exception);
+            error_log($exception);
         }
     }
 }
-- 
cgit v1.2.3